Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Editor] Fix few keyboard shortcuts on mac #15218

Merged
merged 1 commit into from Jul 25, 2022
Merged

[Editor] Fix few keyboard shortcuts on mac #15218

merged 1 commit into from Jul 25, 2022
+9 −4

Conversation

calixteman
Copy link
Contributor

No description provided.

@calixteman calixteman added this to In progress in PDF.js editing via automation Jul 24, 2022
Snuffleupagus
Snuffleupagus approved these changes Jul 24, 2022
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Typo in the commit message (and PR title), since it should be shortcuts :-P

@calixteman calixteman changed the title [Editor] Fix few keyboard shorcuts on mac [Editor] Fix few keyboard shortcuts on mac Jul 24, 2022
@calixteman
Copy link
Contributor Author

/botio integrationtest

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/0ddb13d690259d9/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/b9d19644adf2a6f/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/0ddb13d690259d9/output.txt

Total script time: 4.54 mins

  • Integration Tests: FAILED

@pdfjsbot
Copy link

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/b9d19644adf2a6f/output.txt

Total script time: 7.23 mins

  • Integration Tests: FAILED

@calixteman
Copy link
Contributor Author

/botio integrationtest

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/48f1821fc48585e/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/a5882e8f4b274bc/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/48f1821fc48585e/output.txt

Total script time: 4.60 mins

  • Integration Tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/a5882e8f4b274bc/output.txt

Total script time: 9.18 mins

  • Integration Tests: FAILED

@calixteman calixteman merged commit 14a8b81 into mozilla:master Jul 25, 2022
PDF.js editing automation moved this from In progress to Done Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
editor
Projects
No open projects
PDF.js editing
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@calixteman @pdfjsbot @Snuffleupagus