[api-minor][Annotations] charLimit === 0 means unlimited (bug 1782564) #15329
Conversation
calixteman
force-pushed
the
1782564
branch
2 times, most recently
from
beb9854
to
c2e45bd
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/e45498c84296a55/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/ffa1ed660579ba0/output.txt |
Snuffleupagus
changed the title
src/display/annotation_layer.js
Outdated
| return; | ||
| } | ||
| value = value.slice(0, charLimit); | ||
| event.target.value = elementData.userValue = value; |
There was a problem hiding this comment.
Nit: Would it work with just the following?
| event.target.value = elementData.userValue = value; | |
| target.value = elementData.userValue = value; |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/e45498c84296a55/output.txt Total script time: 26.40 mins
Image differences available at: http://54.241.84.105:8877/e45498c84296a55/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/ffa1ed660579ba0/output.txt Total script time: 29.37 mins
Image differences available at: http://54.193.163.58:8877/ffa1ed660579ba0/reftest-analyzer.html#web=eq.log |
Changing the charLimit in JS had no impact, so this patch aims to fix that and add an integration test for it.
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/150bf453e529625/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/26cfa38aa4d799a/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/150bf453e529625/output.txt Total script time: 26.38 mins
Image differences available at: http://54.241.84.105:8877/150bf453e529625/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/26cfa38aa4d799a/output.txt Total script time: 28.86 mins
|
Changing the charLimit in JS had no impact, so this patch aims to fix
that and add an integration test for it.