Don't replace cr by a white space when the last char on the line is an ideographic char #15395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
approved these changes
Sep 4, 2022
test/pdfs/.gitignore
Outdated
| @@ -538,3 +538,5 @@ | |||
| !bug1782186.pdf | |||
| !tracemonkey_a11y.pdf | |||
| !bug1782564.pdf | |||
| !issue15340.pdf | |||
|
|
|||
There was a problem hiding this comment.
Nit: One new-line too many at the here.
web/pdf_find_controller.js
Outdated
| @@ -248,6 +248,15 @@ function normalize(text) { | |||
| } | |||
|
|
|||
| if (p4) { | |||
| // An ideographic at the end of a line doesn't imply toadd an extra | |||
There was a problem hiding this comment.
Spelling/grammar nit:
Suggested change
| // An ideographic at the end of a line doesn't imply toadd an extra | |
| // An ideographic at the end of a line doesn't imply adding an extra |
…n ideographic char
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/82fa2ed9ec3ac3d/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/1b2060460dd95b3/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/82fa2ed9ec3ac3d/output.txt Total script time: 3.22 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/1b2060460dd95b3/output.txt Total script time: 6.57 mins
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.