Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary function names in the src/core/worker.js file #15706

Merged
merged 2 commits into from Nov 19, 2022
Merged

Remove unnecessary function names in the src/core/worker.js file #15706

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2a2001
Remove unnecessary function names in the `src/core/worker.js` file
Snuffleupagus Nov 17, 2022
70d362f
Remove an unnecessary variable in `getPdfManager`, in the `src/core/w…
Snuffleupagus Nov 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
51 changes: 25 additions & 26 deletions src/core/worker.js
View file
Open in desktop
Expand Up @@ -68,7 +68,7 @@ class WorkerTask {
class WorkerMessageHandler {
static setup(handler, port) {
let testMessageProcessed = false;
handler.on("test", function wphSetupTest(data) {
handler.on("test", function (data) {
if (testMessageProcessed) {
return; // we already processed 'test' message once
}
Expand All @@ -78,11 +78,11 @@ class WorkerMessageHandler {
handler.send("test", data instanceof Uint8Array);
});

handler.on("configure", function wphConfigure(data) {
handler.on("configure", function (data) {
setVerbosityLevel(data.verbosity);
});

handler.on("GetDocRequest", function wphSetupDoc(data) {
handler.on("GetDocRequest", function (data) {
return WorkerMessageHandler.createDocumentHandler(data, port);
});
}
Expand Down Expand Up @@ -303,7 +303,7 @@ class WorkerMessageHandler {
}
cachedChunks = [];
};
const readPromise = new Promise(function (resolve, reject) {
new Promise(function (resolve, reject) {
const readChunk = function ({ value, done }) {
try {
ensureNotTerminated();
Expand Down Expand Up @@ -335,8 +335,7 @@ class WorkerMessageHandler {
}
};
fullRequest.read().then(readChunk, reject);
});
readPromise.catch(function (e) {
}).catch(function (e) {
pdfManagerCapability.reject(e);
cancelXHRs = null;
});
Expand Down Expand Up @@ -427,7 +426,7 @@ class WorkerMessageHandler {
.then(pdfManagerReady, onFailure);
}

handler.on("GetPage", function wphSetupGetPage(data) {
handler.on("GetPage", function (data) {
return pdfManager.getPage(data.pageIndex).then(function (page) {
return Promise.all([
pdfManager.ensure(page, "rotate"),
Expand All @@ -445,28 +444,28 @@ class WorkerMessageHandler {
});
});

handler.on("GetPageIndex", function wphSetupGetPageIndex(data) {
handler.on("GetPageIndex", function (data) {
const pageRef = Ref.get(data.num, data.gen);
return pdfManager.ensureCatalog("getPageIndex", [pageRef]);
});

handler.on("GetDestinations", function wphSetupGetDestinations(data) {
handler.on("GetDestinations", function (data) {
return pdfManager.ensureCatalog("destinations");
});

handler.on("GetDestination", function wphSetupGetDestination(data) {
handler.on("GetDestination", function (data) {
return pdfManager.ensureCatalog("getDestination", [data.id]);
});

handler.on("GetPageLabels", function wphSetupGetPageLabels(data) {
handler.on("GetPageLabels", function (data) {
return pdfManager.ensureCatalog("pageLabels");
});

handler.on("GetPageLayout", function wphSetupGetPageLayout(data) {
handler.on("GetPageLayout", function (data) {
return pdfManager.ensureCatalog("pageLayout");
});

handler.on("GetPageMode", function wphSetupGetPageMode(data) {
handler.on("GetPageMode", function (data) {
return pdfManager.ensureCatalog("pageMode");
});

Expand All @@ -478,15 +477,15 @@ class WorkerMessageHandler {
return pdfManager.ensureCatalog("openAction");
});

handler.on("GetAttachments", function wphSetupGetAttachments(data) {
handler.on("GetAttachments", function (data) {
return pdfManager.ensureCatalog("attachments");
});

handler.on("GetJavaScript", function wphSetupGetJavaScript(data) {
handler.on("GetJavaScript", function (data) {
return pdfManager.ensureCatalog("javaScript");
});

handler.on("GetDocJSActions", function wphSetupGetDocJSActions(data) {
handler.on("GetDocJSActions", function (data) {
return pdfManager.ensureCatalog("jsActions");
});

Expand All @@ -496,7 +495,7 @@ class WorkerMessageHandler {
});
});

handler.on("GetOutline", function wphSetupGetOutline(data) {
handler.on("GetOutline", function (data) {
return pdfManager.ensureCatalog("documentOutline");
});

Expand All @@ -508,18 +507,18 @@ class WorkerMessageHandler {
return pdfManager.ensureCatalog("permissions");
});

handler.on("GetMetadata", function wphSetupGetMetadata(data) {
handler.on("GetMetadata", function (data) {
return Promise.all([
pdfManager.ensureDoc("documentInfo"),
pdfManager.ensureCatalog("metadata"),
]);
});

handler.on("GetMarkInfo", function wphSetupGetMarkInfo(data) {
handler.on("GetMarkInfo", function (data) {
return pdfManager.ensureCatalog("markInfo");
});

handler.on("GetData", function wphSetupGetData(data) {
handler.on("GetData", function (data) {
return pdfManager.requestLoadedStream().then(function (stream) {
return stream.bytes;
});
Expand Down Expand Up @@ -694,7 +693,7 @@ class WorkerMessageHandler {
}
);

handler.on("GetOperatorList", function wphSetupRenderPage(data, sink) {
handler.on("GetOperatorList", function (data, sink) {
const pageIndex = data.pageIndex;
pdfManager.getPage(pageIndex).then(function (page) {
const task = new WorkerTask(`GetOperatorList: page ${pageIndex}`);
Expand Down Expand Up @@ -739,7 +738,7 @@ class WorkerMessageHandler {
});
});

handler.on("GetTextContent", function wphExtractText(data, sink) {
handler.on("GetTextContent", function (data, sink) {
const pageIndex = data.pageIndex;

pdfManager.getPage(pageIndex).then(function (page) {
Expand Down Expand Up @@ -783,7 +782,7 @@ class WorkerMessageHandler {
});
});

handler.on("GetStructTree", function wphGetStructTree(data) {
handler.on("GetStructTree", function (data) {
return pdfManager.getPage(data.pageIndex).then(function (page) {
return pdfManager.ensure(page, "getStructTree");
});
Expand All @@ -793,11 +792,11 @@ class WorkerMessageHandler {
return pdfManager.fontFallback(data.id, handler);
});

handler.on("Cleanup", function wphCleanup(data) {
handler.on("Cleanup", function (data) {
return pdfManager.cleanup(/* manuallyTriggered = */ true);
});

handler.on("Terminate", function wphTerminate(data) {
handler.on("Terminate", function (data) {
terminated = true;

const waitOn = [];
Expand Down Expand Up @@ -828,7 +827,7 @@ class WorkerMessageHandler {
});
});

handler.on("Ready", function wphReady(data) {
handler.on("Ready", function (data) {
setupDoc(docParams);
docParams = null; // we don't need docParams anymore -- saving memory.
});
Expand Down