Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce duplication when dispatching the "switchannotationeditorparams" event #16248

Merged

Conversation

Snuffleupagus
Copy link
Collaborator

Currently we repeat virtually the same code multiple times, which can be avoided by the introduction of a simple helper function.

…" event

Currently we repeat virtually the same code multiple times, which can be avoided by the introduction of a simple helper function.
@Snuffleupagus
Copy link
Collaborator Author

/botio integrationtest

@pdfjsbot
Copy link

pdfjsbot commented Apr 3, 2023

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/59627ae875bbf9c/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Apr 3, 2023

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/59627ae875bbf9c/output.txt

Total script time: 4.33 mins

  • Integration Tests: Passed

Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@Snuffleupagus Snuffleupagus merged commit 96a3210 into mozilla:master Apr 3, 2023
3 checks passed
@Snuffleupagus Snuffleupagus deleted the editor-params-dispatchEvent branch April 3, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants