Improve Puppeteer's trimCache API usage
#16519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original `trimCache` functionality was intended to be exposed on the top-level `puppeteer` module, but due to a bug in Puppeteer this didn't work correctly and we had to call `trimCache` on the default Puppeteer node instance instead, which was fortunately exposed. However, since this didn't feel like intended API usage, this bug was reported and is now fixed in Puppeteer 20.5.0, so this commits updates Puppeteer to that version so we can use the intended API. The full history of this issue can be found at puppeteer/puppeteer#10174.
Snuffleupagus
approved these changes
Jun 4, 2023
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/7754ce490db7ccc/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/ef9fbb51e3b3603/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/7754ce490db7ccc/output.txt Total script time: 24.75 mins
Image differences available at: http://54.241.84.105:8877/7754ce490db7ccc/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/ef9fbb51e3b3603/output.txt Total script time: 33.64 mins
Image differences available at: http://54.193.163.58:8877/ef9fbb51e3b3603/reftest-analyzer.html#web=eq.log |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original
trimCachefunctionality was intended to be exposed on the top-levelpuppeteermodule, but due to a bug in Puppeteer this didn't work correctly and we had to calltrimCacheon the default Puppeteer node instance instead, which was fortunately exposed. However, since this didn't feel like intended API usage, this bug was reported and is now fixed in Puppeteer 20.5.0, so this commits updates Puppeteer to that version so we can use the intended API.The full history of this issue can be found at puppeteer/puppeteer#10174.