[api-minor] Replace the useOnlyCssZoom option with maxCanvasPixels = 0 instead (PR 16729 follow-up)
#16731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
force-pushed
the
rm-useOnlyCssZoom
branch
from
c017598
to
ce0b679
Compare
Snuffleupagus
force-pushed
the
rm-useOnlyCssZoom
branch
from
ce0b679
to
077df3a
Compare
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/ca735052ac47b05/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/ca735052ac47b05/output.txt Total script time: 1.43 mins Published |
Snuffleupagus
force-pushed
the
rm-useOnlyCssZoom
branch
2 times, most recently
from
9877ee8
to
d1bcfd5
Compare
timvandermeij
requested changes
Jul 29, 2023
… = 0` instead (PR 16729 follow-up) Given that the `useOnlyCssZoom` option is essentially just a special-case of the `maxCanvasPixels` functionality, we can combine the two options in order to simplify the overall implementation. Note that the `useOnlyCssZoom` functionality was only ever used, by default, in the PDF Viewer for the B2G/FirefoxOS project (which was abandoned years ago).
Snuffleupagus
force-pushed
the
rm-useOnlyCssZoom
branch
from
d1bcfd5
to
0ee2a35
Compare
timvandermeij
approved these changes
Jul 29, 2023
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that the
useOnlyCssZoomoption is essentially just a special-case of themaxCanvasPixelsfunctionality, we can combine the two options in order to simplify the overall implementation.Note that the
useOnlyCssZoomfunctionality was only ever used, by default, in the PDF Viewer for the B2G/FirefoxOS project (which was abandoned years ago).