Tweak the useWorkerFetch default value checks (PR 15879 follow-up)
#16758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
changed the title
useWorkerFetch default value checks (PR 15879)useWorkerFetch default value checks (PR 15879 follow-up)
Snuffleupagus
force-pushed
the
cMapUrl-standardFontDataUrl-validation
branch
from
86c8a63
to
0154f2f
Compare
Currently we accidentally accept `cMapUrl` and `standardFontDataUrl` parameters that are empty strings or `null`, since e.g. `new URL(null, document.baseURI)` doesn't throw, when validating the `useWorkerFetch` parameter via the `isValidFetchUrl` helper function. Please note that we are currently failing gracefully in this case, as intended, however the warning-messages printed in the console are perhaps less helpful without this patch.
Snuffleupagus
force-pushed
the
cMapUrl-standardFontDataUrl-validation
branch
from
0154f2f
to
c09bd55
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 1 Live output at: http://54.241.84.105:8877/8e72ac68c1ee778/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 1 Live output at: http://54.193.163.58:8877/ab83064a4720425/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/8e72ac68c1ee778/output.txt Total script time: 26.29 mins
Image differences available at: http://54.241.84.105:8877/8e72ac68c1ee778/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/ab83064a4720425/output.txt Total script time: 38.16 mins
Image differences available at: http://54.193.163.58:8877/ab83064a4720425/reftest-analyzer.html#web=eq.log |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we accidentally accept
cMapUrlandstandardFontDataUrlparameters that are empty strings ornull, since e.g.new URL(null, document.baseURI)doesn't throw, when validating theuseWorkerFetchparameter via theisValidFetchUrlhelper function.Please note that we are currently failing gracefully in this case, as intended, however the warning-messages printed in the console are perhaps less helpful without this patch.