Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Editor] When an editor is unselected give the focus to the current page #16762

Merged
merged 1 commit into from
Jul 27, 2023
Merged

[Editor] When an editor is unselected give the focus to the current page #16762

merged 1 commit into from
Jul 27, 2023

Conversation

calixteman
Copy link
Contributor

Follow-up of #16756.

@calixteman calixteman added this to In progress in PDF.js editing via automation Jul 27, 2023
@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/f2a9007bfa5cab7/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/cd9cba3215d97b9/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/cd9cba3215d97b9/output.txt

Total script time: 4.82 mins

  • Integration Tests: FAILED

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/f2a9007bfa5cab7/output.txt

Total script time: 17.51 mins

  • Integration Tests: FAILED

Snuffleupagus
Snuffleupagus approved these changes Jul 27, 2023
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with comments addressed; thank you!

test/integration/freetext_editor_spec.js Outdated Show resolved Hide resolved
test/integration/freetext_editor_spec.js Outdated Show resolved Hide resolved
@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/71108e275d6ff6c/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/e455a255d1ce467/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/e455a255d1ce467/output.txt

Total script time: 4.34 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/71108e275d6ff6c/output.txt

Total script time: 17.29 mins

  • Integration Tests: FAILED

@calixteman calixteman merged commit 0b715e2 into mozilla:master Jul 27, 2023
3 checks passed
PDF.js editing automation moved this from In progress to Done Jul 27, 2023
@calixteman calixteman deleted the editor_focus branch July 27, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
editor
Projects
No open projects
PDF.js editing
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@calixteman @moz-tools-bot @Snuffleupagus