Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a standard export statement in the web/pdfjs.js file #17052

Merged
merged 1 commit into from
Oct 1, 2023

Commits on Sep 30, 2023

  1. Use a standard export statement in the web/pdfjs.js file

    This removes the only remaining old and non-standard handling of exports in the `web/`-folder, since some initial attempts at outputting JavaScript modules in the builds have identified this file as a potential problem.
    While this uses a hard-coded list, for overall simplicity, I don't believe that that's a big problem since:
     - Generating this file automatically would require a bunch more parsing *every single time* that the library is built.
     - The official API-surface doesn't change often enough for this to really impede development in any significant way.
     - The added unit-test helps ensure that this list cannot accidentally become outdated.
    Snuffleupagus committed Sep 30, 2023
    Configuration menu
    Copy the full SHA
    9624505 View commit details
    Browse the repository at this point in the history