Output pdf.scripting.js as a JavaScript module (PR 17055 follow-up)

[Snuffleupagus]

To avoid problems with export statements in the QuickJS Javascript Engine, we can work-around that by explicitly exposing pdfjsScripting globally instead.

[calixteman]

The sandbox is initialized with some code:

pdf.js/src/pdf.sandbox.js

Line 61 in 905ad1f

const code = [PDFJSDev.eval("PDF_SCRIPTING_JS_SOURCE")];

and the generated code (the value of PDFJSDev.eval("PDF_SCRIPTING_JS_SOURCE")) contains at the end:

export { __webpack_exports__initSandbox as initSandbox };

and it's likely why it isn't working correctly.
If try to export something on this quickjs demo: http://numcalc.com/ then we get a syntax error for the export keyword.
That said, I'm not sure to understand what it'd mean to export something here.

[Snuffleupagus]

If try to export something on this quickjs demo: http://numcalc.com/ then we get a syntax error for the export keyword.

I wonder if that demo is just outdated, since the "Introduction"-section at https://bellard.org/quickjs/ contains (emphasis mine):

QuickJS is a small and embeddable Javascript engine. It supports the ES2020 specification including modules, asynchronous generators, proxies and BigInt.

[Snuffleupagus]

That said, I'm not sure to understand what it'd mean to export something here.

It appears that removing that, and manually exposing the necessary object globally, works; note the updated patch.

[Snuffleupagus]

/botio unittest

[moz-tools-bot]

From: Bot.io (Windows)

---

Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/fd8e9263e5e3ba9/output.txt

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/f6379de308978f0/output.txt

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Success

Full output at http://54.241.84.105:8877/f6379de308978f0/output.txt

Total script time: 2.50 mins

• Unit Tests: Passed

[moz-tools-bot]

From: Bot.io (Windows)

---

Success

Full output at http://54.193.163.58:8877/fd8e9263e5e3ba9/output.txt

Total script time: 10.72 mins

• Unit Tests: Passed

[timvandermeij]

The last commit here looks good to me, with one optional comment. Thanks!

[Snuffleupagus]

/botio xfatest

[moz-tools-bot]

From: Bot.io (Windows)

---

Received

Command cmd_xfatest from @Snuffleupagus received. Current queue size: 1

Live output at: http://54.193.163.58:8877/3c7a1b26b910079/output.txt

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Received

Command cmd_xfatest from @Snuffleupagus received. Current queue size: 1

Live output at: http://54.241.84.105:8877/7a1d688b5468e3b/output.txt

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Failed

Full output at http://54.241.84.105:8877/7a1d688b5468e3b/output.txt

Total script time: 10.52 mins

• Font tests: Passed
• Unit tests: Passed
• Integration Tests: Passed
• Regression tests: FAILED

  different ref/snapshot: 2

Image differences available at: http://54.241.84.105:8877/7a1d688b5468e3b/reftest-analyzer.html#web=eq.log

[moz-tools-bot]

From: Bot.io (Windows)

---

Failed

Full output at http://54.193.163.58:8877/3c7a1b26b910079/output.txt

Total script time: 19.94 mins

• Font tests: Passed
• Unit tests: Passed
• Integration Tests: FAILED
• Regression tests: FAILED

  different ref/snapshot: 1

Image differences available at: http://54.193.163.58:8877/3c7a1b26b910079/reftest-analyzer.html#web=eq.log