Update the examples/-folder to account for outputting of JavaScript modules (PR 17055 follow-up)
#17081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
force-pushed
the
examples-modules
branch
2 times, most recently
from
8efe5cf
to
1b8fefa
Compare
Snuffleupagus
force-pushed
the
examples-modules
branch
from
1b8fefa
to
57e644c
Compare
Snuffleupagus
force-pushed
the
examples-modules
branch
5 times, most recently
from
ba7988e
to
a7f2a6e
Compare
… modules (PR 17055 follow-up) This patch also changes most examples to use "top level await", since that's now supported and slightly simplifies the code.
- Remove the `errorWrapper`-element, since it simplifies the example and is consistent with the default viewer; see PR 15533. - Simplify the l10n-handling, since the `NullL10n` should be able to translate everything e.g. without fallback values; see PR 17146.
…modules (PR 17055 follow-up) *Please note:* While following the steps in the README still works with this patch, in the sense that the example runs and successfully renders a PDF document, I unfortunately cannot tell if it illustrates Webpack best practices.
Snuffleupagus
force-pushed
the
examples-modules
branch
from
a7f2a6e
to
d7b39fe
Compare
|
The only way to test this is locally, by running Hopefully we should be getting pretty close to releasing version
|
|
Yes, I agree it's a good idea to wait a bit longer with the final 4.0 release so we have enough time to finish up the last few issues/PRs and do more testing. I'll have a look at this PR soon. |
timvandermeij
approved these changes
Oct 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch also changes most examples to use "top level await", since that's now supported and slightly simplifies the code.