Improve performance of optional content parsing

[calixteman]

No description provided.

[calixteman]

@Snuffleupagus, I don't have a pdf for testing correctly that stuff but at least unit tests are ok locally.
A user shared a profile on the pdf.js channel which shew that we spend a lot of time in Array.includes so this patch should fix this issue.
Here's the profile:
Firefox 2023-10-24 12.17 profile.json.gz

[Snuffleupagus]

I don't have a pdf for testing correctly that stuff

That's really unfortunate!

but at least unit tests are ok locally.

What about the reference tests though, since that seems much more relevant given that optionalContent directly affects rendering?

• First of all, please make sure that this passes all tests.
• Secondly, please get the user to test this patch and confirm that it actually helps.

[calixteman]

/botio test

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/4000d45d5dd12ff/output.txt

[moz-tools-bot]

From: Bot.io (Windows)

---

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/dcc321c303c72b2/output.txt

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Failed

Full output at http://54.241.84.105:8877/4000d45d5dd12ff/output.txt

Total script time: 24.78 mins

• Font tests: Passed
• Unit tests: Passed
• Integration Tests: Passed
• Regression tests: FAILED

  different ref/snapshot: 18
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/4000d45d5dd12ff/reftest-analyzer.html#web=eq.log

[moz-tools-bot]

From: Bot.io (Windows)

---

Failed

Full output at http://54.193.163.58:8877/dcc321c303c72b2/output.txt

Total script time: 36.77 mins

• Font tests: FAILED
• Unit tests: Passed
• Integration Tests: FAILED
• Regression tests: FAILED

  different ref/snapshot: 20

Image differences available at: http://54.193.163.58:8877/dcc321c303c72b2/reftest-analyzer.html#web=eq.log

[calixteman]

/botio-linux preview

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Received

Command cmd_preview from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/9dccddd7a186d74/output.txt

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Success

Full output at http://54.241.84.105:8877/9dccddd7a186d74/output.txt

Total script time: 1.43 mins

Published

• Viewer: http://54.241.84.105:8877/9dccddd7a186d74/web/viewer.html
• Viewer (legacy): http://54.241.84.105:8877/9dccddd7a186d74/legacy/web/viewer.html

[Snuffleupagus]

Let's land this since nothing breaks, and given that the profile shared on Matrix suggests a noticeable improvement.
This really seems like the best we can do without access to the PDF document in question.

r=me, thank you!