Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't take into account the INVISIBLE flag for well-known annotations #17171

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Don't take into account the INVISIBLE flag for well-known annotations #17171

merged 1 commit into from
Oct 25, 2023

Conversation

calixteman
Copy link
Contributor

No description provided.

@calixteman calixteman linked an issue Oct 25, 2023 that may be closed by this pull request
Support for Displaying Image Stamps in Signed PDFs #17169
Closed
Snuffleupagus
Snuffleupagus reviewed Oct 25, 2023
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the changes in this patch, it doesn't feel entirely meaningful to review it until all tests are shown to be passing.

src/core/annotation.js Outdated Show resolved Hide resolved
test/unit/annotation_spec.js Show resolved Hide resolved
@calixteman
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/15f770be07a5b27/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/aaca3640d5e153f/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/15f770be07a5b27/output.txt

Total script time: 24.99 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 15
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/15f770be07a5b27/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/aaca3640d5e153f/output.txt

Total script time: 36.68 mins

  • Font tests: FAILED
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 21

Image differences available at: http://54.193.163.58:8877/aaca3640d5e153f/reftest-analyzer.html#web=eq.log

Snuffleupagus
Snuffleupagus approved these changes Oct 25, 2023
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, thank you!

@calixteman calixteman merged commit 3ba68f6 into mozilla:master Oct 25, 2023
3 checks passed
@calixteman
Copy link
Contributor Author

/botio makeref

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/865c5b345b569f1/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/865c5b345b569f1/output.txt

Total script time: 23.58 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@calixteman
Copy link
Contributor Author

/botio-linux makeref

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/d59caf334b730b8/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/d59caf334b730b8/output.txt

Total script time: 19.30 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
annotations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for Displaying Image Stamps in Signed PDFs
3 participants
@calixteman @moz-tools-bot @Snuffleupagus