Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pause translation when appending the outline/attachment/layer trees to the sidebar #17176

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Pause translation when appending the outline/attachment/layer trees to the sidebar #17176

merged 1 commit into from
Oct 25, 2023

Conversation

Snuffleupagus
Copy link
Collaborator

@Snuffleupagus Snuffleupagus commented Oct 25, 2023 •
edited

Also, pause translation when collapsing/expanding subtrees.

@Snuffleupagus Snuffleupagus added viewer l10n Localization labels Oct 25, 2023
@Snuffleupagus
Copy link
Collaborator Author

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/34fbc192b7c2b1c/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/34fbc192b7c2b1c/output.txt

Total script time: 1.45 mins

Published

@Snuffleupagus
Copy link
Collaborator Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/87b6e165ba64e53/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/1f2d3657d256748/output.txt

@Snuffleupagus
Pause translation when appending the outline/attachment/layer trees t…
6b265b3 
…o the sidebar

Also, pause translation when collapsing/expanding subtrees.
@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/87b6e165ba64e53/output.txt

Total script time: 5.47 mins

  • Integration Tests: Passed

calixteman
calixteman approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you very much.

@Snuffleupagus Snuffleupagus merged commit 806ac67 into mozilla:master Oct 25, 2023
3 checks passed
@Snuffleupagus Snuffleupagus deleted the BaseTreeViewer-pause-l10n branch October 25, 2023 15:51
@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/1f2d3657d256748/output.txt

Total script time: 18.85 mins

  • Integration Tests: Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calixteman calixteman calixteman approved these changes

Assignees
No one assigned
Labels
l10n Localization viewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Snuffleupagus @moz-tools-bot @calixteman