Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix integration tests on Mac #17189

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Fix integration tests on Mac #17189

merged 2 commits into from
Oct 27, 2023

Conversation

calixteman
Copy link
Contributor

It's mainly a matter of keyboard shortcuts.
And it fixes few intermittents.

@calixteman
Copy link
Contributor Author

FYI, locally everything is green on Mac, Linux (Ubuntu through WSL2 on Windows 11) and Windows.

Snuffleupagus
Snuffleupagus reviewed Oct 26, 2023
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's mainly a matter of keyboard shortcuts.
And it fixes few intermittents.

Could these two things perhaps be split into two separate commits (but in the same PR), since fixing the keyboard shortcuts feels like a mostly mechanical change and given the size of this it's a bit difficult to (easily) spot the "intermittents"-part?

test/integration/test_utils.mjs Outdated Show resolved Hide resolved
test/integration/test_utils.mjs Outdated Show resolved Hide resolved
@whimboo
Copy link
Contributor

whimboo commented Oct 26, 2023

Closes #17181.

@whimboo
Copy link
Contributor

whimboo commented Oct 26, 2023

I can confirm that this PR fixes all the issues that I have seen over on #17181 for both Firefox and Chrome with the CDP protocol enabled. Thanks a lot!

Snuffleupagus
Snuffleupagus approved these changes Oct 27, 2023
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with a few suggestions and passing test; thank you!

test/integration/freetext_editor_spec.mjs Outdated Show resolved Hide resolved
test/integration/test_utils.mjs Outdated Show resolved Hide resolved
test/integration/test_utils.mjs Outdated Show resolved Hide resolved
test/integration/test_utils.mjs Outdated Show resolved Hide resolved
test/integration/test_utils.mjs Outdated Show resolved Hide resolved
@Snuffleupagus Snuffleupagus linked an issue Oct 27, 2023 that may be closed by this pull request
Integration tests broken on MacOS because "Control" is used instead of "Meta" for keyboard related tests #17181
Closed
@calixteman
Fix keyboard shortcuts on mac and for some tests make sure that all
517a262 
the page is displayed in using page-fit in order to make all tested
elements visible.
@calixteman
Fix intermittents failure on mac
d72fd9c
@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/5de11bf7442c855/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/fd28713f242b505/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/5de11bf7442c855/output.txt

Total script time: 5.42 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/fd28713f242b505/output.txt

Total script time: 16.74 mins

  • Integration Tests: FAILED

@calixteman calixteman merged commit 6115a32 into mozilla:master Oct 27, 2023
3 checks passed
@calixteman calixteman deleted the mac_integration_test branch October 27, 2023 14:45
@timvandermeij
Copy link
Contributor

Thank you for doing this; extracting those helper functions makes the individual tests easier!

@timvandermeij timvandermeij mentioned this pull request Oct 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integration tests broken on MacOS because "Control" is used instead of "Meta" for keyboard related tests
5 participants
@calixteman @whimboo @moz-tools-bot @timvandermeij @Snuffleupagus