Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pause translation when appending the textLayer and structTreeLayer to the page #17192

Merged
merged 1 commit into from
Oct 29, 2023
Merged

Pause translation when appending the textLayer and structTreeLayer to the page #17192

merged 1 commit into from
Oct 29, 2023

Conversation

Snuffleupagus
Copy link
Collaborator

Note that we must append the textLayer to the DOM before enabling the highlighter and accessibilityManager, to avoid breaking e.g. a pending searching operation.
The least invasive solution, that I was able to come up with, is to introduce a new TextLayerBuilder callback-function for this purpose.

@Snuffleupagus Snuffleupagus added viewer l10n Localization labels Oct 27, 2023
@Snuffleupagus Snuffleupagus changed the title Pause translation when appending the textLayer and structLayer to the page Pause translation when appending the textLayer and structTreeLayer to the page Oct 27, 2023
@Snuffleupagus
Copy link
Collaborator Author

/botio xfatest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_xfatest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/8fb5d307a3e3723/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_xfatest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/45c87d7152991b0/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/8fb5d307a3e3723/output.txt

Total script time: 10.62 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 2

Image differences available at: http://54.241.84.105:8877/8fb5d307a3e3723/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/45c87d7152991b0/output.txt

Total script time: 19.23 mins

  • Font tests: FAILED
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 1

Image differences available at: http://54.193.163.58:8877/45c87d7152991b0/reftest-analyzer.html#web=eq.log

@Snuffleupagus
Copy link
Collaborator Author

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/fbf04057cf6cfe4/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/fbf04057cf6cfe4/output.txt

Total script time: 1.44 mins

Published

@Snuffleupagus
Pause translation when appending the textLayer and structTreeLayer to…
d293048 
… the page

Note that we must append the textLayer to the DOM *before* enabling the `highlighter` and `accessibilityManager`, to avoid breaking e.g. a pending searching operation.
The least invasive solution, that I was able to come up with, is to introduce a new `TextLayerBuilder` callback-function for this purpose.
@Snuffleupagus
Copy link
Collaborator Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/2313c4709815b98/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/5b351a2570b0587/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/2313c4709815b98/output.txt

Total script time: 5.47 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/5b351a2570b0587/output.txt

Total script time: 18.43 mins

  • Integration Tests: FAILED

@Snuffleupagus Snuffleupagus added the release-blocker Blocker for the upcoming release label Oct 28, 2023
timvandermeij
timvandermeij approved these changes Oct 28, 2023
View reviewed changes
Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I'd like Calixte to also sign off on this (after which we can probably close #17150). Thanks!

calixteman
calixteman approved these changes Oct 28, 2023
View reviewed changes
Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@Snuffleupagus Snuffleupagus merged commit 26fc69f into mozilla:master Oct 29, 2023
3 checks passed
@Snuffleupagus Snuffleupagus deleted the textLayer-pause-l10n branch October 29, 2023 08:31
@Snuffleupagus Snuffleupagus mentioned this pull request Oct 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timvandermeij timvandermeij timvandermeij approved these changes

@calixteman calixteman calixteman approved these changes

Assignees
No one assigned
Labels
l10n Localization release-blocker Blocker for the upcoming release viewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Snuffleupagus @moz-tools-bot @timvandermeij @calixteman