Re-factor how some API-options are handled in PDFViewerApplication.open (PR 17208 follow-up)
#17218
Conversation
…werApplication.open` (PR 17208 follow-up) With the changes in PR 17208, where browser-preferences are now handled as "regular" viewer-options, we can tweak the definition of `canvasMaxAreaInBytes` to slightly simplify things in the `PDFViewerApplication.open` method.
…ion.open` Reduce the "special" handling a bit here, by setting the viewer-option such that it'll be automatically included in the API-parameters.
This should be a *tiny* bit more efficient, since it avoids parsing substrings that we don't care about.
|
/botio xfatest |
From: Bot.io (Linux m4)ReceivedCommand cmd_xfatest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/7dac93d6efe1a53/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_xfatest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/67f465badb49184/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/7dac93d6efe1a53/output.txt Total script time: 10.79 mins
Image differences available at: http://54.241.84.105:8877/7dac93d6efe1a53/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/67f465badb49184/output.txt Total script time: 18.73 mins
Image differences available at: http://54.193.163.58:8877/67f465badb49184/reftest-analyzer.html#web=eq.log |
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/0b8aa864720fa52/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/0b8aa864720fa52/output.txt Total script time: 1.44 mins Published |
|
Looks good! |
Please refer to the individual commit messages for additional details.