Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-factor the L10n-implementations to use lowercase language-codes internally #17273

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Re-factor the L10n-implementations to use lowercase language-codes internally #17273

merged 1 commit into from
Nov 14, 2023

Conversation

Snuffleupagus
Copy link
Collaborator

This is consistent with the implementation used in the (now removed) webL10n-library, and by only using lowercase language-codes internally in the L10n-implementations we should avoid future issues e.g. when users manually set the locale-option (in the default viewer).

@Snuffleupagus Snuffleupagus added viewer l10n Localization labels Nov 13, 2023
@Snuffleupagus Snuffleupagus force-pushed the L10n-lowercase-locales branch 2 times, most recently from d800f11 to bd52c0c Compare November 13, 2023 15:26
@Snuffleupagus
Copy link
Collaborator Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/1275dfb498bd7e6/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/19175bab162fdf7/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/19175bab162fdf7/output.txt

Total script time: 25.60 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 14
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/19175bab162fdf7/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/1275dfb498bd7e6/output.txt

Total script time: 34.30 mins

  • Font tests: FAILED
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 20

Image differences available at: http://54.193.163.58:8877/1275dfb498bd7e6/reftest-analyzer.html#web=eq.log

@Snuffleupagus
Re-factor the L10n-implementations to use lowercase language-codes …
1f9533b 
…internally

This is consistent with the implementation used in the (now removed) webL10n-library, and by only using lowercase language-codes internally in the `L10n`-implementations we should avoid future issues e.g. when users manually set the `locale`-option (in the default viewer).
@Snuffleupagus
Copy link
Collaborator Author

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/55e086c96b49222/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/55e086c96b49222/output.txt

Total script time: 1.44 mins

Published

calixteman
calixteman approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@Snuffleupagus Snuffleupagus merged commit 5099dc4 into mozilla:master Nov 14, 2023
9 checks passed
@Snuffleupagus Snuffleupagus deleted the L10n-lowercase-locales branch November 14, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calixteman calixteman calixteman approved these changes

Assignees
No one assigned
Labels
l10n Localization viewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Snuffleupagus @moz-tools-bot @calixteman