Support Annotations with corrupt /BS-entries #17395
Conversation
There's obviously a few things wrong with the Annotations in the referenced PDF document, however parsing of an Annotation shouldn't just break if the /BS-entry isn't a dictionary.
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/7342ce424341806/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/4ce4a8ff2f0086e/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/7342ce424341806/output.txt Total script time: 24.23 mins
Image differences available at: http://54.241.84.105:8877/7342ce424341806/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/4ce4a8ff2f0086e/output.txt Total script time: 36.46 mins
Image differences available at: http://54.193.163.58:8877/4ce4a8ff2f0086e/reftest-analyzer.html#web=eq.log |
…17202 follow-up) It seems this unit-test now fails consistently in "all" up-to-date Node.js versions. We should probably try and understand why, but for now just disable it to get passing CI tests.
Snuffleupagus
force-pushed
the
pypdf-2332
branch
from
0d3f2b2
to
a1d859c
Compare
|
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/bc96ea46a4074c1/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/1087a2d3de5fa6d/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/bc96ea46a4074c1/output.txt Total script time: 18.40 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/1087a2d3de5fa6d/output.txt Total script time: 26.39 mins
|
There's obviously a few things wrong with the Annotations in the referenced PDF document, however parsing of an Annotation shouldn't just break if the /BS-entry isn't a dictionary.
The PDF document was found here: py-pdf/pypdf#2332 (comment)