Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Editor] Draw a line instead of a Bezier curve when an Ink has only one point #17514

Merged
merged 1 commit into from
Jan 15, 2024
Merged

[Editor] Draw a line instead of a Bezier curve when an Ink has only one point #17514

merged 1 commit into from
Jan 15, 2024

Conversation

calixteman
Copy link
Contributor

Fixes #17418.

@calixteman calixteman added this to In progress in PDF.js editing via automation Jan 14, 2024
Snuffleupagus
Snuffleupagus approved these changes Jan 15, 2024
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, thank you!

@calixteman
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/dae49534936b81f/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/38db408f8276d65/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/dae49534936b81f/output.txt

Total script time: 24.52 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 11
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/dae49534936b81f/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/38db408f8276d65/output.txt

Total script time: 38.61 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 27

Image differences available at: http://54.193.163.58:8877/38db408f8276d65/reftest-analyzer.html#web=eq.log

@calixteman calixteman merged commit 7769018 into mozilla:master Jan 15, 2024
9 checks passed
PDF.js editing automation moved this from In progress to Done Jan 15, 2024
@calixteman
Copy link
Contributor Author

/botio makeref

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/af0573bdf95be8d/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/663379b7180c136/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/af0573bdf95be8d/output.txt

Total script time: 18.50 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/663379b7180c136/output.txt

Total script time: 26.64 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@calixteman calixteman deleted the issue17418 branch January 15, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
editor
Projects
No open projects
PDF.js editing
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Single point ink annotation doesn't show on Chrome pdf viewer
3 participants
@calixteman @moz-tools-bot @Snuffleupagus