Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the caret visible in the text layer in caret browsing mode #17533

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Make the caret visible in the text layer in caret browsing mode #17533

merged 1 commit into from
Jan 19, 2024

Conversation

calixteman
Copy link
Contributor

In order to do that we must change the text layer opacity to 1 but it has several implications:

  • the selection color must have an alpha component,
  • the background color of the span used for highlighted words must have an alpha component either, but now the opacity is 1 we can use some backdrop-filters in HCM making the highlighted words more visible.
  • fix a regression caused by Use CSS nesting in the annotationLayer #17196: the css variable --hcm-highlight-filter has to live under the #viewer element because in HCM it's overwritten by js at this level, hence links annotations for example didn't have the right colors when hovered.

Snuffleupagus
Snuffleupagus reviewed Jan 18, 2024
View reviewed changes
web/viewer.css Outdated Show resolved Hide resolved
@calixteman
Copy link
Contributor Author

Here's a screenshot of the results of search in HCM (night sky)
image

Snuffleupagus
Snuffleupagus reviewed Jan 18, 2024
View reviewed changes
web/pdf_viewer.css Outdated Show resolved Hide resolved
@calixteman
Make the caret visible in the text layer in caret browsing mode
83c78db 
In order to do that we must change the text layer opacity to 1 but
it has several implications:
 - the selection color must have an alpha component,
 - the background color of the span used for highlighted words
   must have an alpha component either, but now the opacity is 1
   we can use some backdrop-filters in HCM making the highlighted
   words more visible.
 - fix a regression caused by mozilla#17196: the css variable --hcm-highlight-filter
   has to live under the #viewer element because in HCM it's overwritten
   by js at this level, hence links annotations for example didn't
   have the right colors when hovered.
@Snuffleupagus
Copy link
Collaborator

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/a8da041f4acd38d/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/a8da041f4acd38d/output.txt

Total script time: 1.59 mins

Published

Snuffleupagus
Snuffleupagus approved these changes Jan 19, 2024
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with passing tests; thank you!

@Snuffleupagus
Copy link
Collaborator

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/d4b89667aa49aa2/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/5f46d086b4d0e1a/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/d4b89667aa49aa2/output.txt

Total script time: 24.54 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 16

Image differences available at: http://54.241.84.105:8877/d4b89667aa49aa2/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/5f46d086b4d0e1a/output.txt

Total script time: 40.21 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 24

Image differences available at: http://54.193.163.58:8877/5f46d086b4d0e1a/reftest-analyzer.html#web=eq.log

@calixteman calixteman merged commit 5d2e7cf into mozilla:master Jan 19, 2024
9 checks passed
@calixteman calixteman deleted the caret_mode branch January 19, 2024 14:22
@Snuffleupagus Snuffleupagus mentioned this pull request Jan 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
accessibility text-selection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@calixteman @Snuffleupagus @moz-tools-bot