Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'pagemode' URL parameter #2676

Merged
merged 1 commit into from
Feb 23, 2013
Merged

Add 'pagemode' URL parameter #2676

merged 1 commit into from
Feb 23, 2013

Conversation

Snuffleupagus
Copy link
Collaborator

This PR adds support for the pagemode URL parameter, specified here: http://www.adobe.com/content/dam/Adobe/en/devnet/acrobat/pdfs/pdf_open_parameters_v9.pdf#page=6

@jviereck
Copy link
Contributor

jviereck commented Feb 5, 2013

/botio-linux preview

@pdfjsbot
Copy link

pdfjsbot commented Feb 5, 2013

From: Bot.io (Linux)


Received

Command cmd_preview from @jviereck received. Current queue size: 0

Live output at: http://107.21.233.14:8877/6b5c1aebf252313/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Feb 5, 2013

}
this.switchSidebarView('outline');
} else if (this.sidebarOpen) {
toggle.click();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment here. Was not obvious to me. I you want to "close the sidebar in case it's open"?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you specify pagemode=none or an invalid parameter when opening a file using Adobe Reader, the sidebar won't open. So this is what I was trying to mimic.
But your comment got me thinking that maybe we should only hide the sidebar when pagemode=none, and let it be in whatever state it's in otherwise!? Do you think this would be better?

@jviereck
Copy link
Contributor

jviereck commented Feb 5, 2013

Thanks a lot for this PR - looks good expect the two small things mentioned above.

@waddlesplash
Copy link
Contributor

@jviereck that has been fixed - what's blocking this?

@jviereck
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_preview from @jviereck received. Current queue size: 0

Live output at: http://107.21.233.14:8877/4018b28809cf534/output.txt

@pdfjsbot
Copy link

jviereck added a commit that referenced this pull request Feb 23, 2013
@jviereck jviereck merged commit b9e3e84 into mozilla:master Feb 23, 2013
@jviereck
Copy link
Contributor

@Snuffleupagus thanks a lot for this PR - and thanks @waddlesplash to get me started on it again ;)

@Snuffleupagus
Copy link
Collaborator Author

@jviereck Thanks for merging this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants