-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'pagemode' URL parameter #2676
Conversation
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @jviereck received. Current queue size: 0 Live output at: http://107.21.233.14:8877/6b5c1aebf252313/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/6b5c1aebf252313/output.txt Total script time: 0.15 mins Published |
} | ||
this.switchSidebarView('outline'); | ||
} else if (this.sidebarOpen) { | ||
toggle.click(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a comment here. Was not obvious to me. I you want to "close the sidebar in case it's open"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you specify pagemode=none
or an invalid parameter when opening a file using Adobe Reader, the sidebar won't open. So this is what I was trying to mimic.
But your comment got me thinking that maybe we should only hide the sidebar when pagemode=none
, and let it be in whatever state it's in otherwise!? Do you think this would be better?
Thanks a lot for this PR - looks good expect the two small things mentioned above. |
@jviereck that has been fixed - what's blocking this? |
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @jviereck received. Current queue size: 0 Live output at: http://107.21.233.14:8877/4018b28809cf534/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/4018b28809cf534/output.txt Total script time: 0.15 mins Published |
@Snuffleupagus thanks a lot for this PR - and thanks @waddlesplash to get me started on it again ;) |
@jviereck Thanks for merging this! |
This PR adds support for the
pagemode
URL parameter, specified here: http://www.adobe.com/content/dam/Adobe/en/devnet/acrobat/pdfs/pdf_open_parameters_v9.pdf#page=6