Miscellaneous improvements for the document properties dialog #4167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1486,6 +1486,16 @@ html[dir='rtl'] #documentPropertiesContainer .row > * { | |||
| text-align: right; | |||
| } | |||
|
|
|||
| #documentPropertiesContainer .row span { | |||
| width: 125px; | |||
There was a problem hiding this comment.
Shouldn't this be max-width here as well?
There was a problem hiding this comment.
I tried that, but the problem would still remain. You can try it out by opening the generated viewer and using the web console to change width to max-width and then adding a longer text.
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/28665a6601ef532/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/28665a6601ef532/output.txt Total script time: 0.23 mins Published
|
|
okay, looks good |
yurydelendik
added a commit
that referenced
this pull request
Jan 22, 2014
Miscellaneous improvements for the document properties dialog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR finetunes the document properties implemention from #4149. The following changes have been made:
prompt where it would only be closed if focus was in the text field (which is important to have consistent behaviour).
setFileSizefunction as provided by @Rob--W including the required localization.width (you can use http://www.kennemerlyceum.nl/attachments/article/4/Toelatingsbeleid%202014-2015%20%28laatst%20gewijzigd%20op%206%20november%202013%29.pdf to verify this fix).
by @Rob--W).
document properties dialog (you can use http://www.kennemerlyceum.nl/attachments/article/4/Toelatingsbeleid%202014-2015%20%28laatst%20gewijzigd%20op%206%20november%202013%29.pdf to verify the fix).