Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JPX colors #4397

Merged
merged 1 commit into from
Mar 6, 2014
Merged

Fix JPX colors #4397

merged 1 commit into from
Mar 6, 2014

Conversation

fkaelberer
Copy link
Contributor

Puh, finally. That was a tough one, because there were two independent issues.

Fixes the color/contrast issues reported in #3561 and #4358.
Colors of #2790 and #3181 are also good now.

@Snuffleupagus
Copy link
Collaborator

/botio-linux preview

@pdfjsbot
Copy link

pdfjsbot commented Mar 5, 2014

From: Bot.io (Linux)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/488c5e4fbe81648/output.txt

@Snuffleupagus
Copy link
Collaborator

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Mar 5, 2014

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/89ca644256154a3/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Mar 5, 2014

From: Bot.io (Linux)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/fbc896e7ce9f5dc/output.txt

@timvandermeij
Copy link
Contributor

Linux tests failed. Reference images are here: http://107.21.233.14:8877/fbc896e7ce9f5dc/reftest-analyzer.html#web=eq.log

(Tracking missing Linux bot messages at #4389)

@fkaelberer
Copy link
Contributor Author

Yes, they failed because the colors were wrong, and now they are correct.

@pdfjsbot
Copy link

pdfjsbot commented Mar 5, 2014

From: Bot.io (Windows)


Failed

Full output at http://107.22.172.223:8877/89ca644256154a3/output.txt

Total script time: 35.64 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/89ca644256154a3/reftest-analyzer.html#web=eq.log

@yurydelendik
Copy link
Contributor

@fkaelberer really nice (can you reword the commit message? :)

@fkaelberer
Copy link
Contributor Author

Done ;-)
This commit also adds Line 983, which fixes colors for reversible transforms.

To reproduce the issue that is fixed, create a pdf file from
http://www.gwg.nga.mil/ntb/baseline/software/testfile/Jpeg2000/p0_14/p0_14.j2k

@fkaelberer
Copy link
Contributor Author

/cc @notmasteryet

@yurydelendik
Copy link
Contributor

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Mar 6, 2014

From: Bot.io (Windows)


Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/7b54867ebb3dd9c/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Mar 6, 2014

From: Bot.io (Linux)


Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/5c16d8c68186243/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Mar 6, 2014

From: Bot.io (Linux)


Failed

Full output at http://107.21.233.14:8877/5c16d8c68186243/output.txt

Total script time: 25.09 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.21.233.14:8877/5c16d8c68186243/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Mar 6, 2014

From: Bot.io (Windows)


Failed

Full output at http://107.22.172.223:8877/7b54867ebb3dd9c/output.txt

Total script time: 35.58 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/7b54867ebb3dd9c/reftest-analyzer.html#web=eq.log

@yurydelendik
Copy link
Contributor

/botio makeref

@pdfjsbot
Copy link

pdfjsbot commented Mar 6, 2014

From: Bot.io (Linux)


Received

Command cmd_makeref from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/5b412336a19d6d4/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Mar 6, 2014

From: Bot.io (Windows)


Received

Command cmd_makeref from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/c7224737b76f3b9/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Mar 6, 2014

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/c7224737b76f3b9/output.txt

Total script time: 34.97 mins

  • Lint: Ignored
  • Make references: Passed
  • Check references: Passed

yurydelendik added a commit that referenced this pull request Mar 6, 2014
@yurydelendik yurydelendik merged commit 1857ced into mozilla:master Mar 6, 2014
@yurydelendik
Copy link
Contributor

Thank you for the pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants