Removing set-presence-in-ImageData check from canvas.js #4420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (window.CanvasPixelArray) { | ||
| if (typeof window.CanvasPixelArray.prototype.set !== 'function') { | ||
| window.CanvasPixelArray.prototype.set = function(arr) { | ||
| for (var i = 0, ii = this.length; i < ii; i++) { |
There was a problem hiding this comment.
@timvandermeij Have a look
|
Could you remind me what browsers don't support set()? Also, is there any documentation that only browsers with CanvasPixelArray need the emulated set function? |
|
That's mostly to remove ie9 logic from the main code |
| @@ -507,20 +507,15 @@ var CanvasGraphics = (function CanvasGraphicsClosure() { | |||
|
|
|||
| } else if (imgData.kind === ImageKind.RGBA_32BPP) { | |||
| // RGBA, 32-bits per pixel. | |||
| var haveSetAndSubarray = 'set' in dest && 'subarray' in src; | |||
There was a problem hiding this comment.
@brendandahl Removed!
|
@yurydelendik Is everything okay with the PR now? |
|
Looks good, thank you |
yurydelendik
added a commit
that referenced
this pull request
Mar 13, 2014
…sence Removing set-presence-in-ImageData check from canvas.js
|
oops, forgot /botio-linux test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/912ec6a20012099/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/912ec6a20012099/output.txt Total script time: 26.47 mins
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to Fix #4270