Making src/core/jpx.js adhere to the style guide #4425
Conversation
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.22.172.223:8877/a906452daf078d8/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/a5f17f13ac9b165/output.txt |
| qcc.scalarExpounded = scalarExpounded; | ||
| qcc.guardBits = sqcd >> 5; | ||
| qcc.guardBits = sqcd >> 5; |
There was a problem hiding this comment.
Nit: superfluous space added here.
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/a5f17f13ac9b165/output.txt Total script time: 25.18 mins
|
|
@Snuffleupagus Both nits have been fixed. |
From: Bot.io (Windows)FailedFull output at http://107.22.172.223:8877/a906452daf078d8/output.txt Total script time: 35.73 mins
Image differences available at: http://107.22.172.223:8877/a906452daf078d8/reftest-analyzer.html#web=eq.log |
| @@ -1458,8 +1467,8 @@ var JpxImage = (function JpxImageClosure() { | |||
| this.width = width; | |||
| this.height = height; | |||
|
|
|||
| this.contextLabelTable = subband == 'HH' ? HHContextLabel : | |||
| subband == 'HL' ? HLContextLabel : LLAndLHContextsLabel; | |||
| this.contextLabelTable = (subband == 'HH' ? HHContextLabel : | |||
There was a problem hiding this comment.
Does this qualify as a control statement? If yes this should use strict equalities
There was a problem hiding this comment.
Technically yes, but we have decided to post-phone changing the equalities for now.
The reason is that changing all of them could be very difficult, given that some of the current comparisons might depend on implicit type conversion. (We obviously want to minimize the risk of regressions, particularly this close to the next uplift to mozcentral.)
In the future I personally would like to change those as well, but in this first round of clean-up we decided against it.
|
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/7aa1ba1fed06927/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/07776e164ac81b8/output.txt |
From: Bot.io (Windows)FailedFull output at http://107.22.172.223:8877/07776e164ac81b8/output.txt Total script time: 35.48 mins
Image differences available at: http://107.22.172.223:8877/07776e164ac81b8/reftest-analyzer.html#web=eq.log |
|
Linux also passed. It's annoying that no message is displayed, but it's being tracked. |
Making src/core/jpx.js adhere to the style guide
No description provided.