Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes pages without Resources in their dictionary #4464

Merged
merged 3 commits into from Mar 18, 2014

Conversation

bthorben
Copy link
Contributor

Fix Issue #4461: Pages without \Resources in their dictionary fail to load

When no "\Resource" entry could be found return an empty dictionary

And when I am touching core.js anyway, also refactor and fix the style of Page

@yurydelendik
Copy link
Contributor

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/00f5c4e40dfeb07/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/5d169597363e138/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/00f5c4e40dfeb07/output.txt

Total script time: 25.89 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@yurydelendik
Copy link
Contributor

Looks good with test from #4461 included with reftests as 'load' test (since it's legal pdf).

@yurydelendik yurydelendik changed the title Issue#4461 Fixes pages without Resources in their dictionary Mar 17, 2014
@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/5d169597363e138/output.txt

Total script time: 37.29 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@yurydelendik
Copy link
Contributor

Fixes #3620
Fixes #4334

@bthorben
Copy link
Contributor Author

Improved the comment and removed the nit

@yurydelendik
Copy link
Contributor

(e.g. see 8f3b198 as an example where a "load" test was added)

@bthorben
Copy link
Contributor Author

Ahh, I didn't understand that you want me to add the test ;)
I will quickly do that

Thorben Bochenek added 3 commits March 18, 2014 14:10
@yurydelendik
Copy link
Contributor

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/61ea381a697f8bf/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/1e5352ca391e33b/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/61ea381a697f8bf/output.txt

Total script time: 25.75 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/1e5352ca391e33b/output.txt

Total script time: 37.35 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

yurydelendik added a commit that referenced this pull request Mar 18, 2014
Fixes pages without Resources in their dictionary
@yurydelendik yurydelendik merged commit 329d0ec into mozilla:master Mar 18, 2014
@yurydelendik
Copy link
Contributor

Thank you for the patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants