Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guesses Type1C font type based on file content #4671

Merged
merged 1 commit into from
Apr 24, 2014

Conversation

yurydelendik
Copy link
Contributor

Fixes #4668

@Snuffleupagus
Copy link
Collaborator

Looks good!
I know that this just fixes a special case of bad font data, but should we also include a test file to prevent regressions if someone decides to re-factor this code in the future?

@yurydelendik
Copy link
Contributor Author

Sure, here you go.

@Snuffleupagus
Copy link
Collaborator

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/c82b01b11c783e0/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/02eef1ba116ab2d/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://107.22.172.223:8877/02eef1ba116ab2d/output.txt

Total script time: 2.81 mins

  • Font tests: FAILED
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/02eef1ba116ab2d/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/c82b01b11c783e0/output.txt

Total script time: 25.73 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@yurydelendik
Copy link
Contributor Author

/botio-windows test

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/83a64cdd3d501ad/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/83a64cdd3d501ad/output.txt

Total script time: 21.80 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@Snuffleupagus
Copy link
Collaborator

/botio makeref

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/50a6d0c5778685a/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/c42477f6591b227/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/c42477f6591b227/output.txt

Total script time: 22.43 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/50a6d0c5778685a/output.txt

Total script time: 26.00 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

Snuffleupagus added a commit that referenced this pull request Apr 24, 2014
Guesses Type1C font type based on file content
@Snuffleupagus Snuffleupagus merged commit 0045325 into mozilla:master Apr 24, 2014
@Snuffleupagus
Copy link
Collaborator

Thanks!
I'd be happy to review more PRs with font fixes ;-)

@yurydelendik yurydelendik deleted the issue4668 branch April 25, 2014 02:50
@yurydelendik
Copy link
Contributor Author

Heh, your turn :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PDF document is rendered incorrectly (Error during font loading: dict is undefined")
3 participants