[Firefox] Workaround for sessionStorage error when the preference network.cookie.lifetimePolicy is set to 1 (bug 1000777)

[Snuffleupagus]

The error is described in bug 365772, which is a seven (!) year old bug :-(

Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1000777.

[yurydelendik]

bug 365772 is talking about writing the value has the same issue. shall we add the same below? otherwise looks good

[Snuffleupagus]

I thought about doing that, but was unsure if it would degrade performance to wrap every sessionStorage.setItem in try-catch, since we call ViewHistory.set five times for every call to updateViewarea.
It seems that the error as such isn't the problem here, but rather the fact that it's currently preventing us from resolving the promise.

[Snuffleupagus]

In principle I'd like to add try-catch to setItem as well, so I'd be happy to add that to this PR and then follow-up with a PR that reduces the number of ViewHistory.set calls from 5 -> 1 (per updateViewarea call) if that sounds good.

[yurydelendik]

it would degrade performance to wrap every

I would not worry about performance there, it's a really small price we have to pay

[yurydelendik]

I'd like to add try-catch to setItem as well, so I'd be happy to add that to this PR

Yes, please. Also, ideally we have to reject the promise and handle the rejection on the callee's side. But that can happen in follow up PRs.

[Snuffleupagus]

Done.

/botio-linux preview

[pdfjsbot]

From: Bot.io (Linux)

---

Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/8ed1100eaa04b90/output.txt

[pdfjsbot]

From: Bot.io (Linux)

---

Success

Full output at http://107.21.233.14:8877/8ed1100eaa04b90/output.txt

Total script time: 0.38 mins

Published

• Viewer: http://107.21.233.14:8877/8ed1100eaa04b90/web/viewer.html
• B2G Viewer: http://107.21.233.14:8877/8ed1100eaa04b90/extensions/b2g/content/web/viewer.html
• Extension: http://107.21.233.14:8877/8ed1100eaa04b90/extensions/firefox/pdf.js.xpi
• Extension (AMO): http://107.21.233.14:8877/8ed1100eaa04b90/extensions/firefox/pdf.js.amo.xpi

[yurydelendik]

Thank you