Fixes DownloadManager for IE10 and above #4689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (navigator.msSaveBlob) { // IE10 and above | ||
| var contentType = 'application/octet-stream'; | ||
|
|
||
| // Convert data URI to Uint8Array for blob |
There was a problem hiding this comment.
I think if you will move the data to the downloadData, you don't have to parse the data URI.
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/cd77fae159a9941/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/cd77fae159a9941/output.txt Total script time: 0.38 mins Published
|
yurydelendik
added a commit
that referenced
this pull request
Apr 28, 2014
Fixes DownloadManager for IE10 and above
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4688.
It turns out that it is best to use
navigator.msSaveBlobfor IE10 and above (and possibly older versions, see https://stackoverflow.com/questions/20844644/why-am-i-getting-this-error-in-ie and https://stackoverflow.com/questions/16376161/javascript-set-file-in-download). Because of the feature test, this will only affect IE.