Ensure that the viewer loads even if there are errors when the preferences are read #4693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| this.handTool.activate(); | ||
| } | ||
| }.bind(this)); | ||
| }.bind(this), function rejected(errorMsg) {}); |
There was a problem hiding this comment.
It's just suppressing the unhandled exception error message, right?
There was a problem hiding this comment.
Yes, but this seems to be enough to let the viewer load (it works fine in my testing).
If you prefer another solution, I'm open to suggestions!
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/ffabb34c43fd891/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/ffabb34c43fd891/output.txt Total script time: 0.38 mins Published
|
yurydelendik
added a commit
that referenced
this pull request
Apr 28, 2014
Ensure that the viewer loads even if there are errors when the preferences are read
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to debug #4690, I stumbled on another issue.
Currently if e.g.
Preferences._readFromStoragefails, the PDF document will fail to load. This PR adds missing rejection handler functions, to avoid this issue. (I assumed that it was best to handle this on the caller side, rather than inPreferences.)