Reject polyfill and createPromiseCapability #4700
Conversation
| @@ -992,6 +1007,11 @@ var LegacyPromise = PDFJS.LegacyPromise = (function LegacyPromiseClosure() { | |||
| return new globalScope.Promise(function (resolve) { resolve(x); }); | |||
| }; | |||
| } | |||
| if (typeof globalScope.Promise.reject !== 'function') { | |||
| globalScope.Promise.reject = function (x) { | |||
| return new globalScope.Promise(function (reject) { reject(x); }); | |||
There was a problem hiding this comment.
function (resolve, reject) { reject(x); }
|
Looks good with the lint errors fixes. |
|
Have fixed lint errors and changed |
|
|
||
| /** | ||
| * Creates rejected promise | ||
| * @param reason reason value |
There was a problem hiding this comment.
Wouldn't @param reason rejection value be a better comment here?
|
/botio-linux preview /botio-windows test |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/99b860041e7fc9e/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/dccc229569b41bf/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/99b860041e7fc9e/output.txt Total script time: 0.39 mins Published
|
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/dccc229569b41bf/output.txt Total script time: 22.15 mins
|
Reject polyfill and createPromiseCapability
|
Thank you for the patch |
|
Thanks for merging! On Tue, Apr 29, 2014 at 7:39 PM, Yury Delendik notifications@github.comwrote:
|
No description provided.