Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes rendering of PDFs with nested trailer dictionary #4731

Merged
merged 1 commit into from
May 2, 2014

Conversation

timvandermeij
Copy link
Contributor

@@ -731,12 +731,12 @@ var XRef = (function XRefClosure() {
// The parser goes through the entire stream << ... >> and provides
// a getter interface for the key-value table
var dict = parser.getObj();
if (!isDict(dict)) {
if (!isDict(dict) && !dict.dict) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add if (!isDict(dict) && dict.dict) { dict = dict.dict } above with comment about which generator does it

@timvandermeij timvandermeij changed the title [WIP] Fixes rendering of PDFs with nested trailer dictionary Fixes rendering of PDFs with nested trailer dictionary May 2, 2014
@timvandermeij
Copy link
Contributor Author

/botio-linux preview

@pdfjsbot
Copy link

pdfjsbot commented May 2, 2014

From: Bot.io (Linux)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/6b591cac82b041e/output.txt

@yurydelendik
Copy link
Contributor

/botio test

@pdfjsbot
Copy link

pdfjsbot commented May 2, 2014

From: Bot.io (Windows)


Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/3a4bd87e2b471fd/output.txt

@pdfjsbot
Copy link

pdfjsbot commented May 2, 2014

From: Bot.io (Linux)


Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/6bc48b149a8c3b8/output.txt

@pdfjsbot
Copy link

pdfjsbot commented May 2, 2014

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/3a4bd87e2b471fd/output.txt

Total script time: 22.46 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented May 2, 2014

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/6bc48b149a8c3b8/output.txt

Total script time: 25.77 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@yurydelendik
Copy link
Contributor

Thank you for the patch

yurydelendik added a commit that referenced this pull request May 2, 2014
Fixes rendering of PDFs with nested trailer dictionary
@yurydelendik yurydelendik merged commit f8b3444 into mozilla:master May 2, 2014
@timvandermeij timvandermeij deleted the trailerdict branch May 2, 2014 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants