Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completes unit tests for PostScript evaluator and fixes two bugs in the evaluator itself #4733

Merged
merged 1 commit into from
May 5, 2014

Conversation

timvandermeij
Copy link
Contributor

Primarily in an effort to reduce the amount of TODOs in the code base, but in this case it also proved really useful for finding two undiscovered issues in the PostScript evaluator itself ('neg' and 'not' operators were not handled correctly).

@yurydelendik
Copy link
Contributor

/botio test

@pdfjsbot
Copy link

pdfjsbot commented May 2, 2014

From: Bot.io (Linux)


Received

Command cmd_test from @yurydelendik received. Current queue size: 4

Live output at: http://107.21.233.14:8877/8fe0adbbe94af17/output.txt

@pdfjsbot
Copy link

pdfjsbot commented May 2, 2014

From: Bot.io (Windows)


Received

Command cmd_test from @yurydelendik received. Current queue size: 4

Live output at: http://107.22.172.223:8877/dd3dbeb5b99078a/output.txt

@pdfjsbot
Copy link

pdfjsbot commented May 2, 2014

From: Bot.io (Windows)


Failed

Full output at http://107.22.172.223:8877/dd3dbeb5b99078a/output.txt

Total script time: 22.95 mins

  • Font tests: Passed
  • Unit tests: FAILED
  • Regression tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented May 2, 2014

From: Bot.io (Linux)


Failed

Full output at http://107.21.233.14:8877/8fe0adbbe94af17/output.txt

Total script time: 25.57 mins

  • Font tests: Passed
  • Unit tests: FAILED
  • Regression tests: Passed

@timvandermeij
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented May 3, 2014

From: Bot.io (Windows)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.22.172.223:8877/0558512b8c0fdc1/output.txt

@pdfjsbot
Copy link

pdfjsbot commented May 3, 2014

From: Bot.io (Linux)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/69f6aac9aec47ee/output.txt

@pdfjsbot
Copy link

pdfjsbot commented May 3, 2014

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/0558512b8c0fdc1/output.txt

Total script time: 22.22 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented May 3, 2014

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/69f6aac9aec47ee/output.txt

Total script time: 25.57 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

yurydelendik added a commit that referenced this pull request May 5, 2014
Completes unit tests for PostScript evaluator and fixes two bugs in the evaluator itself
@yurydelendik yurydelendik merged commit b3f24ca into mozilla:master May 5, 2014
@yurydelendik
Copy link
Contributor

Really nice, thanks.

@timvandermeij timvandermeij deleted the postscript-unit-tests branch May 5, 2014 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants