Graphic optimizations 2 #4764

p01 · 2014-05-09T11:45:16Z

This PR mostly improves the expansion of stream buffers by using the builtin copy, and Type4 PostScript functions by simplifying the memoization mechanism and increasing its size to match newest data.

yurydelendik · 2014-05-09T12:07:04Z

src/shared/function.js

-        if (cache.has(key)) {
-          return cache.get(key);
+        var value = cache[key];
+        if(value !== undefined) {


nit: space after if

timvandermeij · 2014-05-09T19:08:16Z

/botio-linux preview

pdfjsbot · 2014-05-09T19:08:18Z

From: Bot.io (Linux)

Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/1f8d2c95a435147/output.txt

pdfjsbot · 2014-05-09T19:09:02Z

From: Bot.io (Linux)

Success

Full output at http://107.21.233.14:8877/1f8d2c95a435147/output.txt

Total script time: 0.74 mins

Published

Viewer: http://107.21.233.14:8877/1f8d2c95a435147/web/viewer.html
B2G Viewer: http://107.21.233.14:8877/1f8d2c95a435147/extensions/b2g/content/web/viewer.html
Extension: http://107.21.233.14:8877/1f8d2c95a435147/extensions/firefox/pdf.js.xpi
Extension (AMO): http://107.21.233.14:8877/1f8d2c95a435147/extensions/firefox/pdf.js.amo.xpi

timvandermeij · 2014-05-09T19:09:55Z

/botio test

pdfjsbot · 2014-05-09T19:09:56Z

From: Bot.io (Linux)

Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/be1568a106f1886/output.txt

pdfjsbot · 2014-05-09T19:18:35Z

From: Bot.io (Windows)

Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.22.172.223:8877/ccac5f0574cb083/output.txt

pdfjsbot · 2014-05-09T19:35:55Z

From: Bot.io (Linux)

Failed

Full output at http://107.21.233.14:8877/be1568a106f1886/output.txt

Total script time: 25.98 mins

Font tests: Passed
Unit tests: Passed
Regression tests: FAILED

Image differences available at: http://107.21.233.14:8877/be1568a106f1886/reftest-analyzer.html#web=eq.log

pdfjsbot · 2014-05-09T19:42:16Z

From: Bot.io (Windows)

Failed

Full output at http://107.22.172.223:8877/ccac5f0574cb083/output.txt

Total script time: 23.68 mins

Font tests: Passed
Unit tests: Passed
Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/ccac5f0574cb083/reftest-analyzer.html#web=eq.log

timvandermeij · 2014-05-12T21:03:59Z

@p01 There appear to be some issues with the gradients. Could you look into that?

p01 · 2014-05-13T08:53:29Z

I'm on it.
With gradients and meshes I just discovered another area of PDF.js to dig further and optimize.

p01 · 2014-05-13T12:53:12Z

The gradients are fine.
I overlooked the fact the input ( domain ) and output ( range ) can have different length.

yurydelendik · 2014-05-13T13:14:20Z

/botio test

pdfjsbot · 2014-05-13T13:14:22Z

From: Bot.io (Linux)

Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/64e67968a6a881f/output.txt

pdfjsbot · 2014-05-13T13:14:22Z

From: Bot.io (Windows)

Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/cd6be1e951a18b8/output.txt

pdfjsbot · 2014-05-13T13:37:46Z

From: Bot.io (Windows)

Failed

Full output at http://107.22.172.223:8877/cd6be1e951a18b8/output.txt

Total script time: 23.40 mins

Font tests: Passed
Unit tests: FAILED
Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/cd6be1e951a18b8/reftest-analyzer.html#web=eq.log

pdfjsbot · 2014-05-13T13:40:31Z

From: Bot.io (Linux)

Failed

Full output at http://107.21.233.14:8877/64e67968a6a881f/output.txt

Total script time: 26.15 mins

Font tests: Passed
Unit tests: FAILED
Regression tests: FAILED

Image differences available at: http://107.21.233.14:8877/64e67968a6a881f/reftest-analyzer.html#web=eq.log

p01 · 2014-05-13T13:40:32Z

Looking at issue1998

yurydelendik · 2014-05-14T15:14:18Z

/botio test

pdfjsbot · 2014-05-14T15:14:19Z

From: Bot.io (Windows)

Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/660dd14421636f4/output.txt

pdfjsbot · 2014-05-14T15:14:19Z

From: Bot.io (Linux)

Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/3496bebf6431a06/output.txt

pdfjsbot · 2014-05-14T15:37:59Z

From: Bot.io (Windows)

Success

Full output at http://107.22.172.223:8877/660dd14421636f4/output.txt

Total script time: 23.68 mins

Font tests: Passed
Unit tests: Passed
Regression tests: Passed

pdfjsbot · 2014-05-14T15:40:14Z

From: Bot.io (Linux)

Success

Full output at http://107.21.233.14:8877/3496bebf6431a06/output.txt

Total script time: 25.91 mins

Font tests: Passed
Unit tests: Passed
Regression tests: Passed

Graphic optimizations 2

yurydelendik · 2014-05-14T17:27:09Z

Looks good, thank you for the patch

p01 · 2014-05-15T09:52:40Z

Thanks!

yurydelendik reviewed May 9, 2014
View reviewed changes

p01 mentioned this pull request May 13, 2014

Slow performance: Chinese PDF #4580

Closed

p01 added 3 commits May 14, 2014 17:06

Optimized function.js / 2x Faster PDFFunction_constructPostScriptFromIR

95fda4f

Optimized colorspace.js AlternateCS_getRgbBuffer

8cfd024

Optimized stream.js / 9-10x faster DecodeStream_ensureBuffer

330b99f

yurydelendik added a commit that referenced this pull request May 14, 2014

Merge pull request #4764 from p01/graphic_optimizations_2

7f6cb0e

Graphic optimizations 2

yurydelendik merged commit 7f6cb0e into mozilla:master May 14, 2014

p01 mentioned this pull request May 15, 2014

Duotone images are very slow #4748

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Graphic optimizations 2 #4764

Graphic optimizations 2 #4764

p01 commented May 9, 2014

yurydelendik May 9, 2014

timvandermeij commented May 9, 2014

pdfjsbot commented May 9, 2014

pdfjsbot commented May 9, 2014

timvandermeij commented May 9, 2014

pdfjsbot commented May 9, 2014

pdfjsbot commented May 9, 2014

pdfjsbot commented May 9, 2014

pdfjsbot commented May 9, 2014

timvandermeij commented May 12, 2014

p01 commented May 13, 2014

p01 commented May 13, 2014

yurydelendik commented May 13, 2014

pdfjsbot commented May 13, 2014

pdfjsbot commented May 13, 2014

pdfjsbot commented May 13, 2014

pdfjsbot commented May 13, 2014

p01 commented May 13, 2014

yurydelendik commented May 14, 2014

pdfjsbot commented May 14, 2014

pdfjsbot commented May 14, 2014

pdfjsbot commented May 14, 2014

pdfjsbot commented May 14, 2014

yurydelendik commented May 14, 2014

p01 commented May 15, 2014

Graphic optimizations 2 #4764

Graphic optimizations 2 #4764

Conversation

p01 commented May 9, 2014

yurydelendik May 9, 2014

Choose a reason for hiding this comment

timvandermeij commented May 9, 2014

pdfjsbot commented May 9, 2014

From: Bot.io (Linux)

Received

pdfjsbot commented May 9, 2014

From: Bot.io (Linux)

Success

Published

timvandermeij commented May 9, 2014

pdfjsbot commented May 9, 2014

From: Bot.io (Linux)

Received

pdfjsbot commented May 9, 2014

From: Bot.io (Windows)

Received

pdfjsbot commented May 9, 2014

From: Bot.io (Linux)

Failed

pdfjsbot commented May 9, 2014

From: Bot.io (Windows)

Failed

timvandermeij commented May 12, 2014

p01 commented May 13, 2014

p01 commented May 13, 2014

yurydelendik commented May 13, 2014

pdfjsbot commented May 13, 2014

From: Bot.io (Linux)

Received

pdfjsbot commented May 13, 2014

From: Bot.io (Windows)

Received

pdfjsbot commented May 13, 2014

From: Bot.io (Windows)

Failed

pdfjsbot commented May 13, 2014

From: Bot.io (Linux)

Failed

p01 commented May 13, 2014

yurydelendik commented May 14, 2014

pdfjsbot commented May 14, 2014

From: Bot.io (Windows)

Received

pdfjsbot commented May 14, 2014

From: Bot.io (Linux)

Received

pdfjsbot commented May 14, 2014

From: Bot.io (Windows)

Success

pdfjsbot commented May 14, 2014

From: Bot.io (Linux)

Success

yurydelendik commented May 14, 2014

p01 commented May 15, 2014