Remove type="text/javascript" from script tags. #4782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"text/javascript" is not a correct MIME type (the correct one is "application/javascript") but it's not even needed; all browsers default to the correct type and treat it as executable JS when type is ommited. Since not all browsers recognize the "application/javascript" MIME type the only way to both stay compliant and to support all popular browsers is to omit the type. It's also shorter this way.
|
/botio-windows preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/66399113b9413f7/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/66399113b9413f7/output.txt Total script time: 0.69 mins Published
|
|
Looks good, thank you for the patch. |
yurydelendik
added a commit
that referenced
this pull request
May 13, 2014
Remove type="text/javascript" from script tags.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"text/javascript" is not a correct MIME type (the correct one is
"application/javascript") but it's not even needed; all browsers default
to the correct type and treat it as executable JS when type is ommited.
Since not all browsers recognize the "application/javascript" MIME type
the only way to both stay compliant and to support all popular browsers
is to omit the type. It's also shorter this way.