Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves colorspace.js and function.js into core/ #4824

Merged
merged 3 commits into from
May 23, 2014

Conversation

yurydelendik
Copy link
Contributor

Fixes #4802

@yurydelendik
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/058a889a9eeedc8/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/9acf33508499fcf/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/9acf33508499fcf/output.txt

Total script time: 24.23 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/058a889a9eeedc8/output.txt

Total script time: 26.58 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@yurydelendik
Copy link
Contributor Author

This also blocks grouping path into figures -- it will make file/stroke color processing operations much simpler

// SCN/scn applies patterns along with normal colors
var pattern;
if (isName(patternName) &&
(pattern = patterns.get(patternName.name))) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: the indentation seems to have become incorrect when copy/pasting the code :-)

Snuffleupagus added a commit that referenced this pull request May 23, 2014
Moves colorspace.js and function.js into core/
@Snuffleupagus Snuffleupagus merged commit 0026075 into mozilla:master May 23, 2014
@Snuffleupagus
Copy link
Collaborator

Looks good to me, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move colorspace to the core/
3 participants