OpenAction support for printing #4833
Conversation
| @@ -475,6 +475,7 @@ var Catalog = (function CatalogClosure() { | |||
| var xref = this.xref; | |||
| var obj = this.catDict.get('Names'); | |||
|
|
|||
| // Parse javascript | |||
There was a problem hiding this comment.
Nit: revert this change
| var action = openactionDict.get('N'); | ||
| var isPrintAction = (isName(objType) && objType.name === 'Action' && | ||
| isName(actionType) && actionType.name === 'Named' && | ||
| isName(action) && action.name === 'Print'); |
There was a problem hiding this comment.
Ideally, lines 514 and 515 should be indented by one more space, but then 80 column limit was exceeded and linting tests failed. So, I left it as it is for the time being. Any suggestions?
There was a problem hiding this comment.
I see. I can live with that. Normally we would do something like:
var isPrintAction = (isName(objType) && objType.name === 'Action' && isName(actionType) && actionType.name === 'Named' && isName(action) && action.name === 'Print');
but that makes it look worse here in my opinion. Let's keep it this way and await final review.
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/656f75cc7e347ca/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/656f75cc7e347ca/output.txt Total script time: 0.71 mins Published
|
|
/botio-windows test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/a5bf48b69003a04/output.txt |
|
/botio-linux test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/20355c0632c1cbd/output.txt |
From: Bot.io (Windows)FailedFull output at http://107.22.172.223:8877/a5bf48b69003a04/output.txt Total script time: 21.73 mins
Image differences available at: http://107.22.172.223:8877/a5bf48b69003a04/reftest-analyzer.html#web=eq.log |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/20355c0632c1cbd/output.txt Total script time: 26.60 mins
|
OpenAction support for printing
|
Thank you for the patch |
Fixes #4698