Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OverlayManager] Add preventDefault to the keydown event handler #4856

Merged
merged 1 commit into from
May 28, 2014
Merged

[OverlayManager] Add preventDefault to the keydown event handler #4856

merged 1 commit into from
May 28, 2014

Conversation

Snuffleupagus
Copy link
Collaborator

If we don't do this, pressing Esc while an overlay is open could abort loading of files for which the server doesn't specify the contentLength.

/cc @timvandermeij

@timvandermeij
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/b6f537f2613c8fa/output.txt

timvandermeij added a commit that referenced this pull request May 28, 2014
…reventDefault

[OverlayManager] Add preventDefault to the keydown event handler
@timvandermeij timvandermeij merged commit 5b16323 into mozilla:master May 28, 2014
@timvandermeij
Copy link
Contributor

Thanks!

@Snuffleupagus Snuffleupagus deleted the overlay-manager-keydown-preventDefault branch May 28, 2014 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants