Added a base64 transparent gif image to links for IE #4868
Conversation
| @@ -1392,6 +1392,11 @@ canvas { | |||
| height: 100%; | |||
| } | |||
|
|
|||
| .annotLink > a /* -ms- */ { | |||
There was a problem hiding this comment.
It looks like you need to add something to the prefix comment for the preprocessor to catch it, changing it to e.g. /* -ms-a */ should work. Could you please fix this and squash the commits?
I'm sorry about giving you the wrong information earlier, I didn't look closely enough at the regexp!
There was a problem hiding this comment.
@Snuffleupagus I had a look at the css rule by inspecting the element and it was only applied to IE when i was testing it. So it must have been picked up. Otherwise, it would have shown up for Firefox as well ... ?!
There was a problem hiding this comment.
I checked out your branch and ran node make firefox locally. When checking the built viewer.css, the CSS rule was still included, but with my proposed change it's not.
Whether or not the rule is actually applied is beside the point! :-)
What we want to avoid is including unnecessary code in the mozcentral/firefox-built versions of PDF.js.
There was a problem hiding this comment.
@Snuffleupagus Ah right, i didn't know how to use the preprocessor. So i just checked what was actually applied in the browser. I totally understand now and agree with you. I will do the change once I get back to work next week. Thanks!
|
@Snuffleupagus Any other changes you want me to do for this commit or is it all good? |
|
/botio-windows preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/3507ac81e0182fe/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/3507ac81e0182fe/output.txt Total script time: 0.99 mins Published
|
Added a base64 transparent gif image to links for IE
|
Looks good, thanks for the patch! |
Fixes #3579