Disable the developer hash parameters by default in PRODUCTION builds of PDF.js #4956
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
pdfBugEnabled
preference, which inPRODUCTION
builds must be set in order to enable the developer hash parameters.Fixes #4954.
Note: To simplify development/debugging, I purposely left the hash parameters enabled by default when the viewer is used in non-production mode, e.g. with
node make server
.Edit: Simpler reviewing with https://github.com/mozilla/pdf.js/pull/4956/files?w=1