Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add strict equalities in src/core/* (part 1) #5116

Merged
merged 6 commits into from Aug 1, 2014
Merged

Add strict equalities in src/core/* (part 1) #5116

merged 6 commits into from Aug 1, 2014

Conversation

Snuffleupagus
Copy link
Collaborator

This addresses files with names beginning with A through to E.

Apart from (obviously) running all the tests locally, I've also as far as it was feasible (i.e. I could find suitable test files) inserted print statements in the code to check that the changes didn't cause any adverse effects.

@timvandermeij Are you up for reviewing?

@timvandermeij
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

pdfjsbot commented Aug 1, 2014

From: Bot.io (Linux)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/9fc3afdf3621d06/output.txt

@timvandermeij
Copy link
Contributor

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Aug 1, 2014

From: Bot.io (Linux)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/4ec8dc38fa0f974/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Aug 1, 2014

From: Bot.io (Windows)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.22.172.223:8877/ba1d61b11b2946f/output.txt

@timvandermeij timvandermeij changed the title Add strict equalities src/core/* (part 1) Add strict equalities in src/core/* (part 1) Aug 1, 2014
@pdfjsbot
Copy link

pdfjsbot commented Aug 1, 2014

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/ba1d61b11b2946f/output.txt

Total script time: 19.93 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented Aug 1, 2014

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/4ec8dc38fa0f974/output.txt

Total script time: 23.07 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

timvandermeij added a commit that referenced this pull request Aug 1, 2014
Add strict equalities in src/core/* (part 1)
@timvandermeij timvandermeij merged commit 00eea3d into mozilla:master Aug 1, 2014
@timvandermeij
Copy link
Contributor

Thank you!

@Snuffleupagus Snuffleupagus deleted the strict-equalities-src-core branch August 1, 2014 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants