Removes some bind() calls from fetchAsync #5140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Much better! Cumulative allocations drop from 725,870,749 bytes to 634,211,099 bytes, and (detected) allocations done by that function drop from 11.7% to 5.4%. |
|
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/cd403f44b45a5d1/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/7d364809fb7f86e/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/7d364809fb7f86e/output.txt Total script time: 19.43 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/cd403f44b45a5d1/output.txt Total script time: 22.20 mins
|
Snuffleupagus
added a commit
that referenced
this pull request
Aug 6, 2014
Removes some bind() calls from fetchAsync
|
Looks good; thanks for the patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5139 ?
/cc @nnethercote