Fixes names collisions in content.js #5314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why don't you put the code in a closure instead (in an immediately self-invoked function)? The revised code still leaks unnecessary globals, such as the |
yurydelendik
force-pushed
the
issue5313
branch
from
55ae745
to
dd48d1c
Compare
Let's do that /botio-windows preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/464390c44358891/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/464390c44358891/output.txt Total script time: 0.94 mins Published
|
|
Fixes #5322 |
brendandahl
added a commit
that referenced
this pull request
Sep 23, 2014
Fixes names collisions in content.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5313
That is one bizarre issue. http://mxr.mozilla.org/mozilla-central/source/browser/components/sessionstore/content/content-sessionStore.js#11 breaks with "Cu is read-only" because we define Cu as
const Cu = Components.utils;