Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactors getDocument and adds PDFDataRangeTransport. #5554

Merged
merged 1 commit into from Jan 8, 2015

Conversation

yurydelendik
Copy link
Contributor

No description provided.

@Snuffleupagus
Copy link
Collaborator

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/f1c739253fa1bcd/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/f7211fa8fad75c0/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/f7211fa8fad75c0/output.txt

Total script time: 17.11 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/f1c739253fa1bcd/output.txt

Total script time: 22.43 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

}

RenderTask.prototype = /** @lends RenderTask.prototype */ {
/**
* Promise for rendering task completion.
* @type {Promise}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: @returns {Promise}.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@yurydelendik
Copy link
Contributor Author

Fixes #5277

@yurydelendik yurydelendik added this to the 2014 Q4 milestone Dec 19, 2014
* @return {Promise} A promise that is resolved after the onFulfilled or
* onRejected callback.
*/
then: function RenderTask_then(onFulfilled, onRejected) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: copy-and-paste error in the function name RenderTask -> PDFDocumentLoadingTask.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@Snuffleupagus
Copy link
Collaborator

Change internalRenderTask -> _internalRenderTask at: https://github.com/mozilla/pdf.js/pull/5554/files#diff-0ecad279ed2252e3eb47a4d96ec1463cR1486.

@yurydelendik
Copy link
Contributor Author

Change internalRenderTask -> _internalRenderTask

Fixed.

*
* @param {function} passwordCallback is optional. It is used to request a
* @param {function} passwordCallback (obsolete) It is used to request a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see we used the word "obsolete" before, but "deprecated" really makes more sense for all of these.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

brendandahl added a commit that referenced this pull request Jan 8, 2015
Refactors getDocument and adds PDFDataRangeTransport.
@brendandahl brendandahl merged commit 6ceb652 into mozilla:master Jan 8, 2015
speedplane pushed a commit to speedplane/pdf.js that referenced this pull request Feb 24, 2015
Refactors getDocument and adds PDFDataRangeTransport.
@yurydelendik yurydelendik deleted the apiref branch January 28, 2016 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants