Move the call to |PDFFindController.resolveFirstPage| into PDFViewer #5721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From reading IRC scrollback, it became clear that having to manually call `PDFFindController.resolveFirstPage` in order for the find functionality to work isn't particulary good. Hence this PR, which moves that code into `PDFViewer.setDocument` to make life easier for third-party implementations.
|
fully agree, makes sense. |
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/b2075fd017727da/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/b2075fd017727da/output.txt Total script time: 0.78 mins Published |
yurydelendik
added a commit
that referenced
this pull request
Feb 27, 2015
…veFirstPage Move the call to |PDFFindController.resolveFirstPage| into PDFViewer
|
Thanks |
speedplane
pushed a commit
to speedplane/pdf.js
that referenced
this pull request
Mar 4, 2015
…r-resolveFirstPage Move the call to |PDFFindController.resolveFirstPage| into PDFViewer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From reading IRC scrollback, it became clear that having to manually call
PDFFindController.resolveFirstPagein order for the find functionality to work isn't particulary good. Hence this PR, which moves that code intoPDFViewer.setDocumentto make life easier for third-party implementations.