Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly detect OpenType font files with CFF data #5770

Merged
merged 1 commit into from Mar 6, 2015
Merged

Correctly detect OpenType font files with CFF data #5770

merged 1 commit into from Mar 6, 2015

Conversation

Snuffleupagus
Copy link
Collaborator

Fixes #5334.
Fixes #215.
Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1093246.
Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1125614.

According to the specification, http://www.microsoft.com/typography/otspec/otff.htm, OpenType font files with CFF data should have OTTO in the header.

Fixes 5334.
Fixes 215.
Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1125614.

According to the specification, http://www.microsoft.com/typography/otspec/otff.htm, OpenType font files with CFF data should have `OTTO` in the header.
@Snuffleupagus
Copy link
Collaborator Author

The Windows failure seems to be, at least partially, connected with HWA (hardware acceleration).
I can reproduce it locally with HWA off, but not with HWA on.

@timvandermeij
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

pdfjsbot commented Mar 4, 2015

From: Bot.io (Linux)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/5471d68c4fc1f49/output.txt

@timvandermeij
Copy link
Contributor

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Mar 6, 2015

From: Bot.io (Linux)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/0bd816b35e05106/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Mar 6, 2015

From: Bot.io (Windows)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.22.172.223:8877/67e363f69767c0b/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Mar 6, 2015

From: Bot.io (Windows)


Failed

Full output at http://107.22.172.223:8877/67e363f69767c0b/output.txt

Total script time: 17.24 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/67e363f69767c0b/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Mar 6, 2015

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/0bd816b35e05106/output.txt

Total script time: 22.13 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@timvandermeij
Copy link
Contributor

/botio makeref

@pdfjsbot
Copy link

pdfjsbot commented Mar 6, 2015

From: Bot.io (Windows)


Received

Command cmd_makeref from @timvandermeij received. Current queue size: 0

Live output at: http://107.22.172.223:8877/118816ba4c3173c/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Mar 6, 2015

From: Bot.io (Linux)


Received

Command cmd_makeref from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/20973fcf20eaf76/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Mar 6, 2015

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/118816ba4c3173c/output.txt

Total script time: 17.37 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

pdfjsbot commented Mar 6, 2015

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/20973fcf20eaf76/output.txt

Total script time: 22.00 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

timvandermeij added a commit that referenced this pull request Mar 6, 2015
Correctly detect OpenType font files with CFF data
@timvandermeij timvandermeij merged commit c69ad58 into mozilla:master Mar 6, 2015
@timvandermeij
Copy link
Contributor

Nice work, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Firefox not rendering myriad pro fonts correctly Cannot render OpenMagazin
3 participants