Embedded Viewer Should Not Override Page Title #5802
Merged
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree that this behavior would be better. |
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/a22ba60d97fbeac/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/a22ba60d97fbeac/output.txt Total script time: 0.78 mins Published |
timvandermeij
added a commit
that referenced
this pull request
Mar 6, 2015
Embedded Viewer Should Not Override Page Title
|
Thank you for the patch! |
|
Great, thanks! First successful pull into master, awesome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simple pull request simply stops embedded viewers from overriding their parent window's page title.
There is often other stuff going on in the page when there is an embedded viewer (including possibly, other embedded viewers) and it seems that the PDF viewer should not override that.