Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further improvements of the getStats and getDownloadInfo unit tests #6147

Merged
merged 1 commit into from Jun 29, 2015
Merged

Further improvements of the getStats and getDownloadInfo unit tests #6147

merged 1 commit into from Jun 29, 2015

Conversation

Snuffleupagus
Copy link
Collaborator

The patch adds a test to ensure that getStats returns the expected result after the page has been parsed, and cleans up the existing test a bit.
Also, since I'm touching the file anyway, I'm making a small adjustment of the getDownloadInfo test. (I have no idea why I didn't just write it like this initially.)

The patch adds a test to ensure that `getStats` returns the expected result after the page has been parsed, and cleans up the existing test a bit.
Also, since I'm touching the file anyway, I'm making a small adjustment of the `getDownloadInfo` test. (I have no idea why I didn't just write it like this initially.)
@Snuffleupagus
Copy link
Collaborator Author

/botio unittest

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/d0fea0e7837f0c4/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/9b0b689c0559b01/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/9b0b689c0559b01/output.txt

Total script time: 0.61 mins

  • Unit Tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://107.22.172.223:8877/d0fea0e7837f0c4/output.txt

Total script time: 0.67 mins

  • Unit Tests: FAILED

@yurydelendik
Copy link
Contributor

/botio-windows test

looks good

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @yurydelendik received. Current queue size: 1

Live output at: http://107.22.172.223:8877/63996e900855136/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/63996e900855136/output.txt

Total script time: 17.97 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@yurydelendik
Copy link
Contributor

Thank you for the patch.

yurydelendik added a commit that referenced this pull request Jun 29, 2015
…tStats-getDownloadInfo

Further improvements of the getStats and getDownloadInfo unit tests
@yurydelendik yurydelendik merged commit 548e4b4 into mozilla:master Jun 29, 2015
@Snuffleupagus Snuffleupagus deleted the api-improved-unittests-getStats-getDownloadInfo branch June 29, 2015 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants